Issue 10626: Do type checks on pass by reference parameters for non-builtin functions and methods. #2939
Conversation
…ons and methods. Initially, all pass by reference parameters were skipped for type checking. This change continues to skip those checks for builtin PHP methods, but does check parameters for userland methods.
|
You've opened the pull request against the latest branch 1.11.x. If your code is relevant on 1.10.x and you want it to be released sooner, please rebase your pull request and change its target to 1.10.x. |
|
Yes, please write a regression test for 8296 😊 Thanks. |
|
Just to be a pain, I've added the test for 8296, but opened the PR against 1.10.x instead. That's at #2941. If it makes sense to keep this one open, I can add the additional test to this PR, or we can just close this one and go with the new one against 1.10.x. |
|
Hey, just a tip - you don't need to close a PR when you just want to change the base. The correct thing to do here would be to change the base in the GitHub UI to 1.10.x, rebase your commits locally on top of 1.10.x (git rebase --onto is a great way to do it) and force-push to the same branch. But you already opened a new PR so I'm going to close this one :) |
Do type checks on pass by reference parameters for non-builtin functions and methods.
Initially, all pass by reference parameters were skipped for type checking. This change continues to skip those checks for builtin PHP methods, but does check parameters for userland methods.