New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PDO::exec could also return false #281

Merged

ondrejmirtes merged 1 commit into phpstan:master from Slamdunk:patch-1

Jul 22, 2020

Contributor

Slamdunk commented Jul 21, 2020

References:


          PDO::exec could also return false

bc364cc

Member

ondrejmirtes commented Jul 21, 2020

So when it actually returns false? Does it depend on the PDO error mode?

Contributor Author

Slamdunk commented Jul 21, 2020

As far as I can tell from php-src, when statement is an empty string or a driver error occurs like https://github.com/php/php-src/blob/c85ded763222295f9d24f8550b9428259bc36e86/ext/pdo_mysql/mysql_driver.c#L259

Member

ondrejmirtes commented Jul 22, 2020

Alright, thank you!

ondrejmirtes merged commit 262694d into phpstan:master

Slamdunk deleted the patch-1 branch

July 22, 2020 12:02

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment