[1.10.x] Create DirectoryCreator helper class

[calebdw]

Hello!

This is similar to #572 --- every other mkdir call is guarded by an is_dir check so I updated this to be consistent.

Thanks!

[phpstan-bot]

You've opened the pull request against the latest branch 1.11.x. If your code is relevant on 1.10.x and you want it to be released sooner, please rebase your pull request and change its target to 1.10.x.

[ondrejmirtes]

As far as PHP is concerned, this code is equivalent. You don't need to check is_dir before calling mkdir, the current code is fine.

I suspect the problem has a different root cause in Pest which should be addressed instead.

[calebdw]

Sure, I get that---likely having to do with how it's capturing warnings. But there's still three other calls to mkdir that are already guarded by an is_dir check so I feel either they should all be guarded or none of them should be guarded for consistency

[ondrejmirtes]

If we wanted to make this consistent everywhere, I'd welcome a new class DirectoryCreator with a static method that would be used in place of these calls.

[calebdw]

@ondrejmirtes done---please let me know if you'd like any other changes

[ondrejmirtes]

After this it's good to merge 👍

[ondrejmirtes]

Thank you.

[ondrejmirtes]

Just did this to improve compatibility with PHPUnit and PHP-Parser 5: 9dac90d