Skip not deprecated methods #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, you’re right, thanks, but we should really cover this with a test too 😊 Thanks. BTW I want to give you some guidance how to implement the friend method stuff, in my mind there aren’t even needed any changes for the phpdoc-parser 😊 Please wait a few moments, I’ll find some time tonight. |
malarzm
force-pushed
the
collecting-deprecations
branch
from
e1b3ac2
to
4a56ca5
Compare
malarzm
force-pushed
the
collecting-deprecations
branch
from
4a56ca5
to
4cf932c
Compare
Here you go!
Thank you very much! I'll gladly compare your way with guesses I made today :D |
|
Thank you, perfect! I'll describe it in phpstan/phpstan#3565. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While roaming around the codebase I have found these two places that seem to not work correctly. Looks like no test was asserting the result so the question is whether shall I write one?