Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix PharData::offsetGet return type #230

Merged
merged 1 commit into from Jun 10, 2020
Merged

fix PharData::offsetGet return type #230

merged 1 commit into from Jun 10, 2020

Conversation

gharlan
Copy link
Contributor

@gharlan gharlan commented Jun 9, 2020

@gharlan gharlan mentioned this pull request Jun 9, 2020
Closed
@ondrejmirtes
Copy link
Member

Thank you! Please also send a PR to https://github.com/JetBrains/phpstorm-stubs/blob/8176ac7986bf1ddd3c0878d67992541e6cdbc214/Phar/Phar.php#L427-L437 and to PHP documentation (https://www.php.net/manual/en/phar.offsetget.php), looks like it's wrong there as well.

@ondrejmirtes ondrejmirtes merged commit 3a2a666 into phpstan:master Jun 10, 2020
@gharlan gharlan deleted the phardata-offsetget branch June 10, 2020 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@gharlan @ondrejmirtes