Remove $otherTypes in FilterFunctionReturnTypeHelper
#2205
Merged
+15
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it should be possible to do this on 1.9.x. |
herndlm
force-pushed
the
remove-other-types
branch
from
f22a409 to
665cdac
Compare
|
yeah, I just selected the wrong branch here / forgot to change to 1.9.x :) |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the last PR
$otherTypeswas only dealing with applying the range options, so I thought it might be a better idea to reflect this somehow and remove the special if conditions in the main method then.I dislike the special handling for
ConstantScalarTypestill, but did not touch it on purpose so far because it started to break existing tests.