Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added regression test #2191

Merged
merged 2 commits into from Jan 20, 2023
Merged

Added regression test #2191

merged 2 commits into from Jan 20, 2023

Conversation

staabm
Copy link
Contributor

@staabm staabm commented Jan 19, 2023 •
edited

@ondrejmirtes
Copy link
Member

There's also 7075 please.

ondrejmirtes
ondrejmirtes requested changes Jan 20, 2023
View reviewed changes
Copy link
Member

@ondrejmirtes ondrejmirtes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure you're seeing these tests fail first. My guess is that the second one is missing $this->treatPhpDocTypesAsCertain = false;.

@staabm
Copy link
Contributor Author

staabm commented Jan 20, 2023

I tested it on 1.9.x and it failed there. wasn't the best idea for this particular test though it seems ;)

@ondrejmirtes ondrejmirtes merged commit 5e5d1b5 into phpstan:1.10.x Jan 20, 2023
@ondrejmirtes
Copy link
Member

Thank you.

@staabm staabm deleted the regres6776 branch January 20, 2023 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ondrejmirtes ondrejmirtes ondrejmirtes requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@staabm @ondrejmirtes