Allow default values for allow-private-mutation properties #2178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zonuexe
commented
Jan 12, 2023
src/Analyser/NodeScopeResolver.php
Outdated
| @@ -534,6 +534,7 @@ private function processStmtNode( | |||
| false, | |||
| $scope->isInTrait(), | |||
| $scope->getClassReflection()->isReadOnly(), | |||
| false | |||
There was a problem hiding this comment.
It seems that there is no processing to get the PHPDoc of the parameter of the constructor promotion, so I ignored it with false.
There was a problem hiding this comment.
There is: https://phpstan.org/r/f22ccc98-94c2-4b7e-9d0f-152bdc575803
But beware - it doesn't mean there's a default value because the code isn't desugared like that.
That's why one is allowed and the other isn't: https://phpstan.org/r/c9757b83-4b83-4ee5-b517-e92e89b44126
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes phpstan/phpstan#8701