New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve constant string support in DateTime return type extensions #2152

Merged

ondrejmirtes merged 1 commit into phpstan:1.9.x from herndlm:date-time-constant-strings

Jan 8, 2023

Contributor

herndlm commented Dec 28, 2022 •

edited

the other DateTime* extensions seem to be using Type::getConstantStrings() already

There are many more extensions that need this and I'll open more PRs after this one most likely :)


          Improve constant string support in DateTime return type extensions

6f829aa

herndlm force-pushed the date-time-constant-strings branch from 4b26b0a to 6f829aa Compare

December 29, 2022 13:06

ondrejmirtes force-pushed the 1.9.x branch from a5d90c1 to a69c7f0 Compare

January 5, 2023 14:23

ondrejmirtes merged commit 1403c03 into phpstan:1.9.x

Member

ondrejmirtes commented Jan 8, 2023

Thank you!

herndlm deleted the date-time-constant-strings branch

January 8, 2023 20:34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment