Fix MixedType::hasOffsetValueType() for subtracted types
#2135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
reviewed
Dec 21, 2022
| @@ -514,6 +514,10 @@ public function isOffsetAccessible(): TrinaryLogic | |||
|
|
|||
| public function hasOffsetValueType(Type $offsetType): TrinaryLogic | |||
| { | |||
| if ($this->isOffsetAccessible()->no()) { | |||
There was a problem hiding this comment.
this makes we wonder whether the API is meant in a way that the caller is expected to check with isOffsetAccessible before calling hasOffsetValueType
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
just stumbled over this by luck. I don't expect it to have much of an influence because most of the code using
hasOffsetValueType()does aisOffsetAccessible()before already. which kind of made me thinking - maybe we should look into how much of a performance impact it has that e.g.hasOffsetValueType()is not cached for big constant arrays, but maybe it doesn't matter any more now..