Refactor options handling in FilterVarDynamicReturnTypeExtension
#2120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
herndlm
force-pushed
the
refactor-options-in-filter-var-dynamic-return-type-extension
branch
from
e91d994
to
5e33509
Compare
herndlm
force-pushed
the
refactor-options-in-filter-var-dynamic-return-type-extension
branch
from
5e33509
to
938036d
Compare
|
This pull request has been marked as ready for review. |
|
Thank you! |
herndlm
deleted the
refactor-options-in-filter-var-dynamic-return-type-extension
branch
|
thx, hopefully I can finally do the actual bug fix now 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like I need a
hasOptions(): TrinaryLogicfor a bug fix which is how I ended up with this refactor. I could also get rid of a couple ofinstanceof ConstantArrayTypeand oneinstanceof ErrorTypein the process. Most likely more similar expressions could be refactored, but this extension is a beast and I wanted to keep the changes small on purpose.