Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use isArray, isConstantArray instead of instanceof in TypeCombinartor::union #2118

Merged
merged 9 commits into from Dec 19, 2022
Merged

Use isArray, isConstantArray instead of instanceof in TypeCombinartor::union #2118

merged 9 commits into from Dec 19, 2022

Commits on Dec 17, 2022

  1. move IterableType union logic to compareTypesInUnion

    @rajyan
    rajyan committed Dec 17, 2022
    Copy the full SHA
    46ee018 View commit details
    Browse the repository at this point in the history

  2. AccessoryTypes themselves are not isArray->yes

    @rajyan
    rajyan committed Dec 17, 2022
    Copy the full SHA
    3558d3d View commit details
    Browse the repository at this point in the history

  3. refactor union of array types by using isArray, isConstantArray

    @rajyan
    rajyan committed Dec 17, 2022
    Copy the full SHA
    3e94bd8 View commit details
    Browse the repository at this point in the history

  4. cs-fix

    @rajyan
    rajyan committed Dec 17, 2022
    Copy the full SHA
    e734fb4 View commit details
    Browse the repository at this point in the history

  5. Revert "AccessoryTypes themselves are not isArray->yes" 

    This reverts commit 984a5d3.
    @rajyan
    rajyan committed Dec 17, 2022
    Copy the full SHA
    116a2be View commit details
    Browse the repository at this point in the history

  6. no need to union AccessoryTypes because classified by `$innerType->de… 

    …scribe(VerbosityLevel::cache())` and they should be same (except HasOffsetValueType)
    @rajyan
    rajyan committed Dec 17, 2022
    Copy the full SHA
    7581b9e View commit details
    Browse the repository at this point in the history

  7. micro optimization

    @rajyan
    rajyan committed Dec 17, 2022
    Copy the full SHA
    b4719b8 View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2022

  1. add failing tests for wrong union result type

    @rajyan
    rajyan committed Dec 19, 2022
    Copy the full SHA
    b611f52 View commit details
    Browse the repository at this point in the history

  2. fix to use isConstantArray in reduceArrays too

    @rajyan
    rajyan committed Dec 19, 2022
    Copy the full SHA
    d0626fb View commit details
    Browse the repository at this point in the history