Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pathinfo($s, PATHINFO_ALL) return type #2014

Merged
merged 2 commits into from Dec 19, 2022
Merged

Conversation

staabm
Copy link
Contributor

@staabm staabm commented Nov 20, 2022

some tests fail with the current release: https://phpstan.org/r/adc64e75-4570-4aeb-acfd-bdcbf88ff872

PATHINFO_ALL is php8 only, see https://3v4l.org/4319K

@staabm staabm marked this pull request as ready for review November 20, 2022 12:59
@phpstan-bot
Copy link
Collaborator

This pull request has been marked as ready for review.

@staabm staabm marked this pull request as draft November 20, 2022 13:07
@staabm staabm marked this pull request as ready for review November 20, 2022 13:20
@phpstan-bot
Copy link
Collaborator

This pull request has been marked as ready for review.

@@ -0,0 +1,15 @@
<?php

namespace pathinfo;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't add two files with the same namespace please :)

@ondrejmirtes
Copy link
Member

Thank you!

@ondrejmirtes ondrejmirtes merged commit 2feb9a7 into phpstan:1.9.x Dec 19, 2022
@staabm staabm deleted the pathinfo branch December 19, 2022 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants