sodium_crypto_generichash* always produce a non-empty-string
#1981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ondrejmirtes
requested changes
Nov 7, 2022
| 'sodium_crypto_generichash_keygen' => ['string'], | ||
| 'sodium_crypto_generichash_update' => ['bool', 'state'=>'string', 'string'=>'string'], | ||
| 'sodium_crypto_generichash' => ['non-empty-string', 'msg'=>'string', 'key='=>'?string', 'length='=>'?int'], | ||
| 'sodium_crypto_generichash_final' => ['non-empty-string', 'state'=>'non-empty-string', 'length='=>'?int'], |
There was a problem hiding this comment.
Declaring parameter as non-empty-string gives me a little pause - what happens when the function receives an empty string? Unless it crashes, I wouldn't require it here.
There was a problem hiding this comment.
That's indeed what happens when you pass an empty string variable:
PHP Fatal error: Uncaught SodiumException: incorrect state length
libsodium is very reliable
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sodium_crypto_generichashfunctions always return states or hashes asnon-empty-stringby design, see