Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update DateTimeZone::listAbbreviations signature #1962

Merged
merged 1 commit into from Nov 5, 2022
Merged

Update DateTimeZone::listAbbreviations signature #1962

merged 1 commit into from Nov 5, 2022

Conversation

franmomu
Copy link
Contributor

@franmomu franmomu commented Nov 4, 2022

Apparently, based on https://www.php.net/manual/en/datetimezone.listabbreviations.php it cannot return false

ondrejmirtes
ondrejmirtes requested changes Nov 4, 2022
View reviewed changes
Copy link
Member

@ondrejmirtes ondrejmirtes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to sync that with timezone_abbreviations_list

@franmomu
Copy link
Contributor Author

franmomu commented Nov 4, 2022

Would be nice to sync that with timezone_abbreviations_list

yeah sure

@ondrejmirtes ondrejmirtes merged commit 9b0b4ed into phpstan:1.9.x Nov 5, 2022
@ondrejmirtes
Copy link
Member

Thank you.

@franmomu franmomu deleted the patch-2 branch November 5, 2022 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ondrejmirtes ondrejmirtes ondrejmirtes requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@franmomu @ondrejmirtes