Fix mt_rand return type #1956
Merged
Fix mt_rand return type #1956
+14
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ondrejmirtes
requested changes
Nov 3, 2022
|
Huh? Nothing at all. I didn't touch it. |
|
It must have somehow been deleted by git automatically because I have .idea in global gitignore... I'll add it back... |
|
You deleted the file. |
|
Fixed. |
staabm
reviewed
Nov 3, 2022
enumag
force-pushed
the
mt-rand
branch
2 times, most recently
from
d9a3dfa to
db12e0d
Compare
enumag
requested review from
canvural and
staabm
and removed request for
ondrejmirtes,
canvural and
staabm
enumag
requested review from
ondrejmirtes and
staabm
and removed request for
ondrejmirtes and
staabm
|
I can't review it when the tests are failing. |
|
@ondrejmirtes Fixed. There is still one failed job but I don't think it's related to my changes: https://github.com/phpstan/phpstan-src/actions/runs/3393592592/jobs/5641134975 |
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes phpstan/phpstan#8272