Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve JUnit error formatter #1722

Merged
merged 1 commit into from
Sep 14, 2022
Merged

Improve JUnit error formatter #1722

merged 1 commit into from
Sep 14, 2022

Conversation

mcaskill
Copy link
Contributor

Resolves phpstan/phpstan#6772

If AnalysisResult has no errors, mark <testsuite> as having 1 test in order to be considered as having passed.

Verified

This commit was signed with the committer’s verified signature.
mcaskill Chauncey McAskill
Resolves phpstan/phpstan#6772

If `AnalysisResult` has no errors, mark `<testsuite>` as having 1 test in order to be considered as having passed.
@ondrejmirtes ondrejmirtes merged commit 29af264 into phpstan:1.8.x Sep 14, 2022
@ondrejmirtes
Copy link
Member

Thank you.

@mcaskill mcaskill deleted the feature/improve-junit-error-formatter branch September 14, 2022 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JUnit formatter incorrectly reports the total number of tests run
2 participants