more precise $argc, $argv global var type #1718
Conversation
| global $argc, $argv; | ||
| \PHPStan\Testing\assertType('mixed', $argc); // should be int<1, max> | ||
| \PHPStan\Testing\assertType('mixed', $argv); // should be non-empty-array<int, string> |
There was a problem hiding this comment.
tried several things, but in the end wasn't able to identify this variable-scope.
therefore left it mixed for now.. I don't think thats a very common thing anyway
(and we can't be 100% sure whether global $argc, $argv actually references the builtin globals or a custom variable)
| \PHPStan\Testing\assertType('int<1, max>', $argc); | ||
| \PHPStan\Testing\assertType('non-empty-array<int, string>', $argv); |
There was a problem hiding this comment.
$argc/$argv always count/contain the program name you pass php test.php, so actually you never have a empty type here.
actually this variable would only exist for a script run via the CLI SAPI, but I don't think we can differentiate CLI and WEB sapi.
FWIW, psalm also allows this 2 vars: https://psalm.dev/r/942a865551 and they are in the process of making them more precise in https://github.com/vimeo/psalm/pull/8473/files. I will look into making the super-globals more precise in a separate PR.
| \PHPStan\Testing\assertType('non-empty-array<int, string>', $argv); | ||
|
|
||
| function f() { | ||
| \PHPStan\Testing\assertType('*ERROR*', $argc); |
There was a problem hiding this comment.
Please put this function in a use statement.
clxmstaab
force-pushed
the
cli-globals
branch
from
0a9465e
to
ba9d2f6
Compare
|
Thank you. |
refs vimeo/psalm#8473