infer non-falsy-string in sscanf() #1662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
force-pushed
the
non-falsy-sscanf
branch
2 times, most recently
from
9ccd893
to
3141f68
Compare
staabm
force-pushed
the
non-falsy-sscanf
branch
from
3141f68
to
37abf1f
Compare
staabm
commented
Aug 31, 2022
| function fooo() { | ||
| function fooo(string $s) { | ||
| // %0s returns the whole string | ||
| assertType('array{non-empty-string|null}|null', sscanf( "0" , "%0s")); | ||
| assertType('array{non-empty-string|null}|null', sscanf( "123456" , "%0s")); |
There was a problem hiding this comment.
actually for a non-falsy-string $string this line could lead to a more precise 'array{non-falsy-string|null}|null', but I feel like %0s as a format is more or less a theoretical thing.. never seen it used anywhere.. I think people would use %s instead.
I figured its not important enough to complicate the extension for it
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.