Add type specifying extension for ctype_digit #1635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
herndlm
reviewed
Aug 18, 2022
|
You may find additional inspiration for the tests in #1615 |
|
Thanks for those tests. I found some edge cases. |
|
Isnt passing ints to ctype_* functions being deprecated? |
|
Yep it is. Supporting existing code which uses it is still good though to e.g. prevent false positives |
ondrejmirtes
requested changes
Aug 20, 2022
|
Please rebase the branch and solve conflicts, thanks :) |
|
No merge commits please, linear history only. |
fluffycondor
force-pushed
the
ctype-digit-extension
branch
from
96182fd
to
6f8b483
Compare
ondrejmirtes
approved these changes
Aug 24, 2022
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.