Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix libxml_get_last_error() signature #155

Merged
merged 1 commit into from
Mar 6, 2020

Conversation

simPod
Copy link
Contributor

@simPod simPod commented Mar 6, 2020

No description provided.

@codecov
Copy link

codecov bot commented Mar 6, 2020

Codecov Report

Merging #155 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #155   +/-   ##
=========================================
  Coverage     85.18%   85.18%           
  Complexity     9667     9667           
=========================================
  Files           541      541           
  Lines         24439    24439           
=========================================
  Hits          20819    20819           
  Misses         3620     3620           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d56c832...2ebd3b9. Read the comment docs.

@ondrejmirtes
Copy link
Member

The same thing is one line above in libxml_get_errors. Please fix that too (and in the rest of the file if you find it too).

@simPod simPod force-pushed the fix-libxml_get_last_error branch from a7d6911 to 2ebd3b9 Compare March 6, 2020 09:14
@ondrejmirtes ondrejmirtes merged commit 5d40bf2 into phpstan:master Mar 6, 2020
@ondrejmirtes
Copy link
Member

Thank you!

@simPod simPod deleted the fix-libxml_get_last_error branch March 6, 2020 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants