Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing parameter to thumbnailImage #154

Merged
merged 1 commit into from
Mar 3, 2020
Merged

Add missing parameter to thumbnailImage #154

merged 1 commit into from
Mar 3, 2020

Conversation

Riimu
Copy link
Contributor

@Riimu Riimu commented Mar 3, 2020

The function map is missing the $legacy parameter for Imagick::thumbnailImage.

The phpstorm stub has the following description for it:

* @param bool $legacy [optional] Added since 3.4.0. Default value FALSE

Additionally, the description to the function describes it as:

* If legacy is true, the calculations are done with the small rounding bug that existed in Imagick before 3.4.0.<br>
* If false, the calculations should produce the same results as ImageMagick CLI does.<br>

@ondrejmirtes ondrejmirtes merged commit 4d69043 into phpstan:master Mar 3, 2020
@ondrejmirtes
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants