Remove undefined constants from scope #1534
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Constants are currently added to the scope if e.g.
defined()
is used and passed around, but never removed anymore. Which this PR changes.The constants are added to the scope via
ConstFetch
expression that is specified in https://github.com/phpstan/phpstan-src/blob/1.8.2/src/Type/Php/DefinedConstantTypeSpecifyingExtension.php#L55MutatingScope
where eitherspecifyExpressionType
orremoveTypeFromExpression
is called depending on sure or sureNotType which is effectively depending on truthy/falsey contextspecifyExpressionType
is adding the constants to the scope in https://github.com/phpstan/phpstan-src/blob/1.8.2/src/Analyser/MutatingScope.php#L3434-L3458removeTypeFromExpression
is callingspecifyExpressionType
again with the removed type (in the constant example with e.g.!defined()
leading to aNeverType
)(Specified)Type-wise this doesn't change anything, but
ConstantRule
explicitly verifies if a constant is in the scope and not which type it has. And this rule is working a bit better now I think.