Change impossible match arms to not contribute to the expressions' resulting union type #1515
+27
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvanvelzen
reviewed
Jul 18, 2022
…s resulting union type.
ondrejmirtes
force-pushed
the
change.impossible-match-arms-expression-result
branch
from
b84a8ac to
189a466
Compare
|
Thank you! About the internals - you'll learn a lot by reading https://phpstan.org/developing-extensions/core-concepts and also maybe https://phpstan.org/writing-php-code/narrowing-types (narrowing types is implemented in TypeSpecifier class). Other than that I'd recommend you to read release notes and see how various bugs are fixed around the codebase. Then try to fix a bug you choose :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let me know if there's something i can do better!
went down the wrong rabbit hole for hours trying to modify the NodeScopeResolver, is there any docs / resources that would be good to learn about how scopes / type inference works internally @ondrejmirtes ? something like that video of Jan talking about types you posted the other day?