Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve in_array extension to get rid of related impossible check adaptions #1514

Closed
wants to merge 6 commits into from
Closed

Improve in_array extension to get rid of related impossible check adaptions #1514

wants to merge 6 commits into from

Commits on Jul 13, 2022

  1. Improve in_array extension to get rid of related impossible check a… 

    …daptions
    @herndlm
    herndlm committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    e994f69 View commit details
    Browse the repository at this point in the history

  2. Simplified things but extracted 2 remaining special cases

    @herndlm
    herndlm committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    b02bd1b View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2022

  1. Add 2 more test cases that are currently OK 

    The array shape should be of a different type I'd say, but I'm surprised this worked at all tbh
    @herndlm
    herndlm committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    12c1301 View commit details
    Browse the repository at this point in the history

  2. Add another constant array test that rules out than optional offset v… 

    …alue is there + document tests
    @herndlm
    herndlm committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    7b35446 View commit details
    Browse the repository at this point in the history

  3. Improve ConstantArrayType handling

    @herndlm
    herndlm committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    7d3a859 View commit details
    Browse the repository at this point in the history

  4. Commit new slevomat errors cause by presumably another bug

    @herndlm
    herndlm committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    46a92e1 View commit details
    Browse the repository at this point in the history