Fix handling of str_split
/ mb_str_split
string arg compound types + default return type for mb_str_split
#1496
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes phpstan/phpstan#7580
There were 2 issues basically which is why I split this into 2 commits
str_split
/mb_str_split
did not handle compound types for the string type correctly (e.g. union of constant strings)mb_str_split
can actually return an empty array. This was adapted in mb_str_split() / str_split() always returnsnon-empty-array
#633 which is based on a psalm adaption, but psalm actually reverted it back in Revert mb_str_split return signature to list<string> vimeo/psalm#6493 becausestr_split
andmb_str_split
differ in behaviour there. See also https://3v4l.org/r6sMeStrSplitFunctionReturnTypeExtension
could need a bit more cleanup, but I wanted to avoid rewriting it here.. Maybe I'll adapt some more in follow-ups.