Fix ConstantArrayType
creation for preg_split
with PREG_SPLIT_OFFSET_CAPTURE
#1486
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: #1484
Looks like it was forgotten to explicitly specifiy
$nextAutoIndexes
correctly in that edge case. And then it falls back to[0]
which can break theConstantArrayTypeBuilder
(since the array keys0
and1
are explicitly specified already).I quickly looked through most of the other ConstantArrayType creations but did not find any more problems.
Fyi the 3 errors, that looked fine to me, are