Add ClosureTypeFactory #1483
Merged
Add ClosureTypeFactory #1483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
canvural
commented
Jun 30, 2022
| return [ | ||
| [static function (): void { | ||
| }, 'void'], | ||
| [static function () { // @phpcs:ignore |
There was a problem hiding this comment.
Wanted to test a case where there is no native return type, but phpcbf was adding void. Needed to ignore it here.
canvural
force-pushed
the
from-closure-object
branch
from
4cb5434
to
49966a9
Compare
|
Perfect, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the discussion.
This PR adds new class
ClosureTypeFactorythat can createClosureTypefrom nativeClosures.This PR doesn't descent into closure body to determine return type like
MutatingScopedoes, but for this use case it should be fine.