New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AllowDynamicProperties stub #1478
Conversation
Needs a regression test in ClassAttributesRuleTest. |
Thank you, will do today |
fc1f8a2
to
6a5ef7f
Compare
Added test but can't make it work on PHP 8.2 but on earlier PHP versions it throws |
6a5ef7f
to
e78744b
Compare
Merged as: d122cf4 It works fine in my opinion. |
Thank you! |
Thanks, as always, @ondrejmirtes ! |
@ondrejmirtes somehow now it fails on PHP 8.2 alpha3 but https://3v4l.org/hIKTZ/rfc#vgit.master reports that class exists
|
It needs to update phpstorm-stubs after PR JetBrains/phpstorm-stubs#1404 |
@andypost Please test 1.8.x-dev with |
@ondrejmirtes thank you! it works! waiting for new release (and this week 8.2 beta1 coming)
|
refs https://wiki.php.net/rfc/deprecate_dynamic_properties
Resolve https://phpstan.org/r/021bc1c5-d27b-4bc8-8974-1a5116b49d9f
phpstan/phpstan#7345 (comment)