Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft: Intersect optimization for large unions #1471

Merged
merged 3 commits into from Jun 24, 2022
Merged

Draft: Intersect optimization for large unions #1471

merged 3 commits into from Jun 24, 2022

Commits on Jun 24, 2022

  1. Optimize inner loop of intersect union search 

    Array slice spends a good bit of time allocating memory for new arrays
even for small arrays. For larger computed unions this can be a
non-trivial amount of time. We can minimize the cost by not repeating
the slice for ever iteration of the inner loop since it doesn't depend
on the loop.
    @neclimdul @ondrejmirtes
    neclimdul authored and ondrejmirtes committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    7a3ebe9 View commit details
    Browse the repository at this point in the history

  2. Optimize type specification intersect logic 

    Don't know if this will have side effects so testing needed but if it
works... oh lord.

Fixes #7421 Slow processing of Class::* type hints
    @neclimdul @ondrejmirtes
    neclimdul authored and ondrejmirtes committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    517bc8f View commit details
    Browse the repository at this point in the history

  3. Adjust test results

    @ondrejmirtes
    ondrejmirtes committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    9abc52c View commit details
    Browse the repository at this point in the history