Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suppress is_file warnings from entry file #1466

Merged
merged 1 commit into from Jun 23, 2022
Merged

Suppress is_file warnings from entry file #1466

merged 1 commit into from Jun 23, 2022

Conversation

mvorisek
Copy link
Contributor

Upper than project directory might be inaccessible.

see https://github.com/phpstan/phpstan/runs/7020331951?check_suite_focus=true#step:6:394

@ondrejmirtes
Copy link
Member

Can you make the test to crash the PHP process (return non-zero) in case of these warnings?

@mvorisek
Copy link
Contributor Author

Good point, I can use some grep magic in phpstan/phpstan#7518

@staabm
Copy link
Contributor

staabm commented Jun 23, 2022 •
edited

I guess you would just need a exception handler which throws a exception on php warnings..?

@mvorisek mvorisek mentioned this pull request Jun 23, 2022
Merged
@ondrejmirtes ondrejmirtes merged commit cc72138 into phpstan:1.7.x Jun 23, 2022
@ondrejmirtes
Copy link
Member

Thank you.

@mvorisek mvorisek deleted the no_open_basedir_warnings branch June 23, 2022 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@mvorisek @ondrejmirtes @staabm