Fix infinite recursion for template intersection type accepts() #1450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvanvelzen
commented
Jun 21, 2022
Comment on lines
-147
to
-150
| if ($acceptingType instanceof self || ($acceptingType instanceof UnionType && !$acceptingType instanceof TemplateUnionType)) { | ||
| return $acceptingType->accepts($this, $strictTypes); | ||
| } | ||
|
|
There was a problem hiding this comment.
Nothing appears to break by removing this 🤷♂️
|
Thank you! Removing code is always nice 😊 |
|
@rvanvelzen @ondrejmirtes Am I wrong or the testBug7500 shouldn't report any error ? https://phpstan.org/r/29203f2e-5b6c-46bf-b91a-baf7d3839591 works fine is it should be Should I open an issue ? |
|
@VincentLanglet Comments on closed PRs tend to get lost, please open a new bug report about this, thanks. |
|
Yes I did it @ondrejmirtes phpstan/phpstan#7511 with a simpler reproducer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes phpstan/phpstan#7500