added SscanfFunctionDynamicReturnTypeExtension return type extension #1434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
commented
Jun 17, 2022
| assertType('int|null', sscanf('20-20', '%d-%d', $first, $second)); | ||
| assertType('array{int, int}|null', sscanf('20-20', '%d-%d')); | ||
|
|
||
| assertType('array{string}|null', sscanf($s, '%c')); |
There was a problem hiding this comment.
staabm
commented
Jun 17, 2022
Comment on lines
8
to
9
| assertType('int|null', sscanf($s, $s, $first, $second)); | ||
| assertType('array|null', sscanf($s, $s)); |
There was a problem hiding this comment.
the 2 test-cases which existed before.. now with just a string format, because otherwise we would not get the same results
There was a problem hiding this comment.
Please change assertions of the existing sscanf('20-20', '%d-%d', $first, $second) test and add sscanf($s, $s, $first, $second) as a separate one.
|
built errors seem unrelated |
ondrejmirtes
requested changes
Jun 17, 2022
Comment on lines
8
to
9
| assertType('int|null', sscanf($s, $s, $first, $second)); | ||
| assertType('array|null', sscanf($s, $s)); |
There was a problem hiding this comment.
Please change assertions of the existing sscanf('20-20', '%d-%d', $first, $second) test and add sscanf($s, $s, $first, $second) as a separate one.
|
Thank you! |
|
Maybe a regression phpstan/phpstan#7764 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.