Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify array type via in_array #1430

Merged
merged 1 commit into from Jun 17, 2022
Merged

Conversation

rvanvelzen
Copy link
Contributor

@rvanvelzen rvanvelzen marked this pull request as draft June 16, 2022 15:14
@herndlm
Copy link
Contributor

herndlm commented Jun 16, 2022

Oh, this was on my todo list as well :) I was hoping we could get rid of some of the specific in_array conditionals in ImpossibleCheckTypeHelper afterwards. Did you check already?

@rvanvelzen
Copy link
Contributor Author

I think so, I'll check tomorrow :)

@rvanvelzen rvanvelzen marked this pull request as ready for review June 17, 2022 07:53
@ondrejmirtes
Copy link
Member

Please send a clean-up in a next PR, I'm eager to see what else this fixes :) Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants