Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update string compare return values #1412

Merged
merged 1 commit into from Jun 14, 2022

Conversation

bytestream
Copy link
Contributor

@staabm
Copy link
Contributor

staabm commented Jun 10, 2022

same for

'strnatcasecmp' => ['int', 's1'=>'string', 's2'=>'string'],
'strnatcmp' => ['int', 's1'=>'string', 's2'=>'string'],
'strncasecmp' => ['int', 'str1'=>'string', 'str2'=>'string', 'len'=>'int'],
'strncmp' => ['int', 'str1'=>'string', 'str2'=>'string', 'len'=>'int'],

?

maybe also substr_compare

additionally a test-case regarding your reported error would be great.

@bytestream
Copy link
Contributor Author

@ondrejmirtes this is 🟢 now 🎉

@ondrejmirtes
Copy link
Member

No merge commits please, but clean linear history on top of 1.7.x.

@bytestream
Copy link
Contributor Author

I've rebased and squashed 👍

@ondrejmirtes ondrejmirtes merged commit 1c9f823 into phpstan:1.7.x Jun 14, 2022
@ondrejmirtes
Copy link
Member

Thank you!

@bytestream bytestream deleted the strcasecmp branch June 14, 2022 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants