ExtendedMethodReflection

[ondrejmirtes]

FYI @rvanvelzen @jrmajor This is my answer to have we can extend what method can tell us about themselves without breaking backward compatibility.

Right now MethodReflection is being used in custom MethodsClassReflectionExtension so we can't add new methods on it. But that doesn't prevent us to work with ExtendedMethodReflection in PHPStan internals.

I imagine that methods like acceptsNamedArguments() and getAsserts() could be added on ExtendedMethodReflection.

[ondrejmirtes]

FYI @canvural I'm getting this error in Larastan:

 ------ --------------------------------------------------------------------- 
  Line   Rules/ModelProperties/ModelPropertyStaticCallRule.php                
 ------ --------------------------------------------------------------------- 
  149    Instanceof between PHPStan\Reflection\ExtendedMethodReflection and   
         NunoMaduro\Larastan\Reflection\EloquentBuilderMethodReflection will  
         always evaluate to false.                                            
 ------ --------------------------------------------------------------------- 

But I don't think I'm doing a BC break here and I don't think you need to do this:

        if ($methodReflection instanceof EloquentBuilderMethodReflection) {
            $methodReflection = $methodReflection->getOriginalMethodReflection();
        }

I think you can continue passing yours EloquentBuilderMethodReflection into modelPropertiesRuleHelper and it should work...

[canvural]

@ondrejmirtes Thanks, I'll take a look.

[canvural]

This was a little bit of BC break I guess. Because previously extensions could return any class that implements MethodReflection But now it'll always be WrappedExtendedMethodReflection But then one could argue you should always work with interfaces not concrete classes 😅 Yeah, correct.

Temporarily I solved this by making EloquentBuilderMethodReflection implement ExtendedMethodReflection instead of MethodReflection (I know bad solution, but it was fastest way for now) Later I'll investigate why EloquentBuilderMethodReflection and getOriginalMethodReflection was needed. It was to carry some information between extensions, but I forgot the root cause.

[ondrejmirtes]

Larastan does this:

        if ($methodReflection instanceof EloquentBuilderMethodReflection) {
            $methodReflection = $methodReflection->getOriginalMethodReflection();
        }

So $methodReflection->getOriginalMethodReflection() is passed further to modelPropertiesRuleHelper because EloquentBuilderMethodReflection itself doesn't work there? Why it doesn't work there?

[canvural]

Honestly no idea! I'll try to dig deeper when I have time.

[ondrejmirtes]

So that's the root cause here - EloquentBuilderMethodReflection should answer everything the same way the wrapped getOriginalMethodReflection() does, and it should work fine :)

[canvural]

If that was the case I'd use the original method reflection directly I guess. There are some differences. For example return type can be different between the original method reflection and EloquentBuilderMethodReflection.