Specify types on get_parent_class() #1383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
commented
Jun 2, 2022
clxmstaab
force-pushed
the
bug5552
branch
3 times, most recently
from
63c70d3
to
823c7d0
Compare
staabm
commented
Sep 26, 2022
src/Analyser/TypeSpecifier.php
Outdated
Comment on lines
337
to
338
| // the is_string() check should not be necessary, since ConstantStringType->getValue() returns 'string' | ||
| && is_string($constantType->getValue()) |
There was a problem hiding this comment.
There was a problem hiding this comment.
fyi @rvanvelzen, the refactoring might conflict with your existing #1761 PR.
clxmstaab
force-pushed
the
bug5552
branch
2 times, most recently
from
3e7a923
to
e91e1f1
Compare
staabm
commented
Sep 27, 2022
| } | ||
| } | ||
|
|
||
| if ( |
There was a problem hiding this comment.
this if block is the only new logic of this PR.
everything else is pre-existing logic which was just factored out into new private methods
staabm
force-pushed
the
bug5552
branch
2 times, most recently
from
fb01d17
to
eae128c
Compare
|
@ondrejmirtes if we could land this one it would unblock some of the already opened PRs for more TypeSpecifier goodness. |
ondrejmirtes
changed the title
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes phpstan/phpstan#5552