Use ReadWritePropertiesExtensions in MissingReadOnlyPropertyAssignRule

[herndlm]

.. and MissingReadOnlyByPhpDocPropertyAssignRuleTest.

Should close phpstan/phpstan#6632
Should close phpstan/phpstan#7337

I kept it simple and chose a similar testing approach as UnusedPrivatePropertyRuleTest uses. I also double-checked - these 2 classes were the only ones were ClassPropertiesNode::getUninitializedProperties was used without passing extensions.

A dedicated test-case in the doctrine extension using readonly might be a good idea too maybe? I assume there are already cases where the ReadWritePropertiesExtension from there is used.

[herndlm]

hmmm, had the same phpstan errors (Strict comparison using === between class-string and 'MissingReadOnlyProp…' will always evaluate to false.) first too, but they went away after an autoloader dump, which makes sense. why here though 🤔
UPDATE: looks like it only happens with PHP < 8.1
UPDATE2: generating a composer classmap for that file with PHP 7.4 seems to be working fine. pretty sure, I'm missing something really simple here. gonna wait a bit, maybe somebody can tell me :D

[herndlm]

Though about this again, not verified yet, but I assume that simply autoloading those PHP 8.1 files won't work in earlier versions. Will check that later and fix it then by conditionally passing the extension.

[ondrejmirtes]

Yeah, should be tested only on 8.1 😊

[herndlm]

still not sure how to solve the static analysis error, any ideas? any additional checks added will always resolve to ConstBooleanTypes before PHP 8.1. It's not a simple case of not running the test on earlier versions unfortunately..

btw the problem is indeed the autoloading, the phpstan checks are all correct here, the class simply cannot be autoloaded and therefore is not a valid class-string before 8.1.

[ondrejmirtes]

I used your first commit and I'm trying to solve the failure in a similar way to how I solved these in the past: 933c0f0

[herndlm]

aaah, thx Ondrej! I actually remember now touching something close to that ignore-by-php-version file already once in the past..

[ondrejmirtes]

Perfect, thank you!