Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ArrayChunkFunctionReturnTypeExtension #1356

Merged
merged 3 commits into from May 29, 2022
Merged

Add ArrayChunkFunctionReturnTypeExtension #1356

merged 3 commits into from May 29, 2022

Conversation

herndlm
Copy link
Contributor

@herndlm herndlm commented May 28, 2022 •
edited

Closes phpstan/phpstan#7277

Finally, after all the recent ConstantArray adaptions regarding optional props, this is now really simple and working as expected :)

ondrejmirtes
ondrejmirtes requested changes May 28, 2022
View reviewed changes
Copy link
Member

@ondrejmirtes ondrejmirtes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise great - this is how it should be done. Make the change easy & make the easy change!

src/Type/Constant/ConstantArrayType.php Show resolved Hide resolved
@herndlm herndlm requested a review from ondrejmirtes May 28, 2022 18:12
@herndlm herndlm marked this pull request as draft May 29, 2022 06:25
@herndlm herndlm marked this pull request as ready for review May 29, 2022 11:19
@ondrejmirtes ondrejmirtes merged commit eac5b1c into phpstan:1.7.x May 29, 2022
@ondrejmirtes
Copy link
Member

Nice, thank you :)

@herndlm herndlm deleted the array-chunk branch May 29, 2022 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ondrejmirtes ondrejmirtes ondrejmirtes requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@herndlm @ondrejmirtes