-
Notifications
You must be signed in to change notification settings - Fork 494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider optional keys in ConstantArrayType::slice
#1345
Conversation
60bbcba
to
286f1b4
Compare
still not sure, about some tests, I'll check this again tomorrow. The behaviour is not correct yet |
Oh yes, it's hard :) |
a70fb09
to
922a531
Compare
I think I made it work. Also added all edge cases I could think of. It's unfortunately far from as elegant as I was hoping, mostly because of negative offsets and lengths/limits. |
78106bb
to
69fb4dc
Compare
Unfortunately I did find one more thing. I'll adapt it in the evening. |
I have a fix locally again, but I was wondering @ondrejmirtes: I saw that many optional key cases seem to be handled via |
I've stopped using |
nice, ok then, I'll need to do something else first then ;) and thx for the immediate answer btw! :) |
OK, I think I'm happy with it now. I did this in 2 commits, the first one extracts generic I changed the return type of |
Thank you very much for figuring this out :) I agree it's not really a BC break. |
This was hard. I think the tests show that it works correct, but tbh., it's a challenge for me to get the more complicated optional examples right in my head :D
There're a couple of more interesting "normal" constant array
array_slice
tests existing already in LegacyNodeScopeResolverTest.