Fix endless recursion with nested traits via anonymous classes #1303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
temporarily reverted the commit to make sure the 3 errors really came from these changes. they do. I still don't understand what they have to do with the parent scope, anonymous classes or traits. could be some MutatingScope internals, or I overlooked something. no idea atm but I'll take another look UPDATE: found it, this was my fault, I seem to have created a CI race condition or wrong runs basically because I initially had 1.7.x as target and switched over to 1.6.x later |
herndlm
force-pushed
the
fix-7214
branch
3 times, most recently
from
aad29aa
to
233e894
Compare
herndlm
commented
May 12, 2022
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes phpstan/phpstan#7214
I'm still not a 100% sure about this. The idea came from the fact that anonymous classes can be nested and therefore it might make sense to pass the parent scope.