Support string accessory types in BitwiseNot #1266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
force-pushed
the
bitwise-not-string-accessories
branch
from
e0aafdc
to
b288633
Compare
|
I don't think it's useful to apply numeric and literal strings this way. Numeric string isn't certainly kept numeric: https://3v4l.org/JERDB |
staabm
force-pushed
the
bitwise-not-string-accessories
branch
from
9524d23
to
2fa51e0
Compare
clxmstaab
force-pushed
the
bitwise-not-string-accessories
branch
from
1fb313c
to
1db480e
Compare
|
just adjusted the PR to only contain the non-empty-string related types.
I thought about whether we should use a ErrorType, or add a Rule for that case. |
clxmstaab
force-pushed
the
bitwise-not-string-accessories
branch
from
1db480e
to
6379aff
Compare
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On my way to kill
instanceof StringTypecases