Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/disallow dynamic property option #1234

Merged
merged 10 commits into from Apr 21, 2022
Merged

Feature/disallow dynamic property option #1234

merged 10 commits into from Apr 21, 2022

Commits on Apr 20, 2022

  1. add failing test for issue-3171

    @rajyan
    rajyan committed Apr 20, 2022
    Copy the full SHA
    e7d204c View commit details
    Browse the repository at this point in the history

  2. recursively allow undefined expressions in coalesce, isset, empty

    @rajyan
    rajyan committed Apr 20, 2022
    Copy the full SHA
    36a99ed View commit details
    Browse the repository at this point in the history

  3. add checkDynamicProperties feature

    @rajyan
    rajyan committed Apr 20, 2022
    Copy the full SHA
    da04ef7 View commit details
    Browse the repository at this point in the history

  4. change $currentlyAllowedUndefinedExpressions to `array<string, true… 

    …>` because false will not be set anymore
    @rajyan
    rajyan committed Apr 20, 2022
    Copy the full SHA
    93aad95 View commit details
    Browse the repository at this point in the history

  5. cs fix

    @rajyan
    rajyan committed Apr 20, 2022
    Copy the full SHA
    370b649 View commit details
    Browse the repository at this point in the history

  6. fix duplicate class name

    @rajyan
    rajyan committed Apr 20, 2022
    Copy the full SHA
    a876c5a View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2022

  1. move checkDynamicProperties to AccessPropertiesRule

    @rajyan
    rajyan committed Apr 21, 2022
    Copy the full SHA
    f12c7ca View commit details
    Browse the repository at this point in the history

  2. configure checkDynamicProperties in test

    @rajyan
    rajyan committed Apr 21, 2022
    Copy the full SHA
    0f5a31c View commit details
    Browse the repository at this point in the history

  3. add tests for checkDynamicProperties

    @rajyan
    rajyan committed Apr 21, 2022
    Copy the full SHA
    e64bc9a View commit details
    Browse the repository at this point in the history

  4. Access to an undefined property should be appropriate for these cases. 

    Should be fixed by specifying types in isset.
Related issue phpstan/phpstan#3171
    @rajyan
    rajyan committed Apr 21, 2022
    Copy the full SHA
    a624060 View commit details
    Browse the repository at this point in the history