Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/coalesce simulate ternary #1192

Closed
wants to merge 5 commits into from
Closed

Fix/coalesce simulate ternary #1192

wants to merge 5 commits into from

Conversation

rajyan
Copy link
Contributor

@rajyan rajyan commented Apr 9, 2022 •
edited

@rajyan
Copy link
Contributor Author

rajyan commented Apr 9, 2022

Mostly done, but have to unify the results of IssetRule and NullCoalesceRule correctly to avoid duplicate reports.

@rajyan rajyan force-pushed the fix/coalesce-simulate-ternary branch from aec267c to fbfa65e Compare April 9, 2022 05:00
@rajyan rajyan force-pushed the fix/coalesce-simulate-ternary branch from fbfa65e to fa43aab Compare April 9, 2022 05:06
@rajyan rajyan marked this pull request as draft April 9, 2022 06:09
@ondrejmirtes ondrejmirtes mentioned this pull request Apr 9, 2022
Closed
@rajyan rajyan mentioned this pull request Apr 9, 2022
Merged
@rajyan
Copy link
Contributor Author

rajyan commented Apr 9, 2022 •
edited

I'll close this one if #1193 passes

@rajyan rajyan closed this Apr 9, 2022
@rajyan rajyan deleted the fix/coalesce-simulate-ternary branch April 11, 2022 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@rajyan