mark readline* function having side-effects

[staabm]

see https://www.php.net/manual/de/book.readline.php

inspired by vimeo/psalm#7828

[staabm]

btw: I am wondering why phpstan does not report errors atm https://phpstan.org/r/91377db4-0029-494f-935b-83c619fa5f06
but psalm does https://psalm.dev/r/eb33a31483

[staabm]

This needs to be adjusted like described by ondrey in #698 (comment)

[staabm]

added the instructions from #698 (comment) into the generated file, to hopefully ease the contributor experience

[ondrejmirtes]

Hi, can you please first verify that these records actually need to be added by some tests? Ideally NodeScopeResolverTest + CallToFunctionStatementWithoutSideEffectsRule. It's possible that PHPStan already knows exactly what's going on.

Also the "generated" message in the generated file should be in a separate PR if we decide the readline changes in this one aren't needed :)

[staabm]

It's possible that PHPStan already knows exactly what's going on.

hmm ok.. this might explain, why I don't see errors in the background, even this entries are missing.

btw: I am wondering why phpstan does not report errors atm phpstan.org/r/91377db4-0029-494f-935b-83c619fa5f06

---

Also the "generated" message in the generated file should be in a separate PR if we decide the readline changes in this one aren't needed :)

I will adjust this PR to only include the generated-file-comment (I will not change the PR title accordingly)

[ondrejmirtes]

Thank you.