Fix huge union types result from "+"-array-merge operation #1141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ondrejmirtes
requested changes
Mar 29, 2022
|
I tried for more then an hour, but it seems I am not able to come up with a proper NodeScopeResolverTest for it. either my fix only works by accident, or I am really not able to create the test... I don't know right now. |
|
finally found a test-case which works locally. lets see what CI is thinking about it that was a hard one for me. |
|
Perfect, thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with the fix we apply the limit already used in
ConstantArrayTypeBuilderalso to the merge-process when analyzing constant-arrays beeing merged by the+-operator.without the fix, the provided testcase runs 2-4 minutes. with the fix it runs in 3-5 seconds.
closes phpstan/phpstan#6936