#6840 Report useless array filter #1076
Conversation
leongersen
force-pushed
the
useless-array-filter
branch
2 times, most recently
from
ac3e420
to
25797c9
Compare
| return []; | ||
| } | ||
|
|
||
| $args = array_values($node->getArgs()); |
There was a problem hiding this comment.
is the array_values call necessary?
|
I guess this PR should target the 1.4.x branch |
leongersen
force-pushed
the
useless-array-filter
branch
from
25797c9
to
43cf87f
Compare
|
I've created a new PR to 1.4.x: #1077 |
|
Not entirely sure, if it really should target the 1.4.x branch, but regarding the rebase: I think an interactive rebase would have worked where you have to manually drop all the new commits from 1.5.x. In case you need to do something like that again :) |
|
Hi, it's unfortunate but you should always evaluate every review with critical thinking :) This is absolutely a new feature, hence it should target 1.5.x |
|
No problem! I'm learning things along the way 😄 . I can't reopen this PR, but I've rebased the new one to 1.5.x.
|
Ok it seems we have a different understanding about the branches and what is considered a feature or not. IMO #1067 was also a new feature 🤷♂️ |
(I don't have access to PHP8 right now, I'll have to fix the build in the CLI)
Implements phpstan/phpstan#6840