Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix is_subclass_of with same class #1044

Merged
merged 3 commits into from
Mar 2, 2022
Merged

Fix is_subclass_of with same class #1044

merged 3 commits into from
Mar 2, 2022

Conversation

herndlm
Copy link
Contributor

@herndlm herndlm commented Mar 2, 2022 •
edited

@herndlm herndlm force-pushed the fix-is-subclass-of-with-same-class branch from 6091f27 to 479c9a1 Compare March 2, 2022 10:01
@herndlm
Copy link
Contributor Author

herndlm commented Mar 2, 2022 •
edited

weird, make is working fine on my local env. need to check later.
UPDATE: Nope, now broken too. That's what I get from not doing composer install and blindly rebasing... Now the results also make more sense to me :)

@herndlm herndlm force-pushed the fix-is-subclass-of-with-same-class branch 4 times, most recently from 684c046 to f3bb892 Compare March 2, 2022 12:51
@herndlm herndlm force-pushed the fix-is-subclass-of-with-same-class branch from 9435340 to 70fd1fb Compare March 2, 2022 13:37
@herndlm herndlm marked this pull request as ready for review March 2, 2022 15:54
@ondrejmirtes ondrejmirtes merged commit 2d52a5b into phpstan:master Mar 2, 2022
@ondrejmirtes
Copy link
Member

Thank you!

@herndlm herndlm deleted the fix-is-subclass-of-with-same-class branch March 2, 2022 16:22
@mvorisek
Copy link
Contributor

mvorisek commented Mar 2, 2022 •
edited

@herndlm please see phpstan/phpstan#6305 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@herndlm @ondrejmirtes @mvorisek