Support for class-string $class parameter in is_subclass_of() #1039
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for $class parameter of type class-string in is_subclass_of().
I tried to unify the logic for the cases when $class is a constant string, a class string, or something else.
I also tried to narrow the specified type when we know that the $object parameter is either a string or an object. For example if the parameter is a string, it will no longer be specified as class-string|object.
There is one caveat: the type specifier extension may now specify the $object parameter as
*NEVER*
in some impossible cases. Is this acceptable ?This fixes phpstan/phpstan#6698