Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more precise preg_match_all return type on php8 #1023

Merged
merged 1 commit into from Mar 2, 2022

Conversation

staabm
Copy link
Contributor

@staabm staabm commented Feb 18, 2022

fixes issue reported in #918 (comment)

@Seldaek
Copy link
Contributor

Seldaek commented Feb 18, 2022

👍Thanks

@staabm staabm marked this pull request as ready for review February 18, 2022 14:54
@ondrejmirtes
Copy link
Member

Coding standard failing here. Run make cs locally to check it.

@staabm
Copy link
Contributor Author

staabm commented Feb 23, 2022

args, the error slipped in while rebasing.. sorry for that.. fixed

@clxmstaab clxmstaab force-pushed the preg-fixes branch 2 times, most recently from 2f3e106 to 3943f6f Compare February 28, 2022 18:25
@ondrejmirtes
Copy link
Member

Thank you.

@staabm staabm deleted the preg-fixes branch March 2, 2022 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants